-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Passing in Tokenized Data to One-Shot #2202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
requested review from
rahul-tuli,
dbogunowicz,
bfineran,
dsikka,
horheynm and
robertgshaw2-neuralmagic
March 28, 2024 20:55
UX LGTM Can you validate it works with a model that does not accept labels? e.g. swap in the following model = AutoModel.from_pretrained("BAAI/bge-small-en-v1.5")
recipe = """
test_stage:
obcq_modifiers:
SparseGPTModifier:
sparsity: 0.5
targets: ["re:encoder.layer.\\d+$"]
""" .. |
@robertgshaw2-neuralmagic Confirmed this worked with the following recipe:
Only hiccup is "BAAI/bge-small-en-v1.5" didn't have support for device_map auto, but it was small enough to fit on one GPU |
…to tokenized_inputs
bfineran
previously approved these changes
Apr 1, 2024
bfineran
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing a tokenized dataset to
sparseml.transformers.oneshot
. See OneShot UX Enhancement doc for feature details. If the user passes in a dataset smaller than num_calibration_samples, we throw a warning and just use the smaller dataset.Previously we were handling dataset shuffling within our code. I added a new
shuffle_calibration_samples
flag to disable this, to support cases where a user wants to shuffle the data themselves and keep that ordering. This wasn't in the original UX requirement, so definitely open to feedback on taking this out or adjusting it. See the unit test for an exampleExample Script